Exclude packages changed from packageconfig diff#2
Merged
jeremie-dautheribes merged 1 commit intobootlin:mainfrom Mar 25, 2026
Merged
Exclude packages changed from packageconfig diff#2jeremie-dautheribes merged 1 commit intobootlin:mainfrom
jeremie-dautheribes merged 1 commit intobootlin:mainfrom
Conversation
When a package that has some PACKAGECONFIG is added or remove, all its packageconfigs are shown in the diff, which may drastically increase the output. The aim of spdx-diff is to get a clear output of changes from two builds. It makes sense to ignore packages changes in the packageconfig diff. Signed-off-by: Louis Rannou <louis.rannou@non.se.com>
Member
|
@Louson some tests are still failing, could you have a look please? |
Collaborator
|
@jeremie-dautheribes Well I think bootlin/meta-spdx-diff-test#1 needs to be merged first |
jeremie-dautheribes
added a commit
to bootlin/meta-spdx-diff-test
that referenced
this pull request
Mar 25, 2026
Following bootlin/spdx-diff#2, update the generated SBOMs. Signed-off-by: Jérémie Dautheribes <jeremie.dautheribes@bootlin.com>
Member
|
Following bootlin/meta-spdx-diff-test@141b231 the tests now run correctly, so I'll merge it. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a package that has some PACKAGECONFIG is added or remove, all its packageconfigs are shown in the diff, which may drastically increase the output.
The aim of spdx-diff is to get a clear output of changes from two builds. It makes sense to ignore packages changes in the packageconfig diff.
Requires bootlin/meta-spdx-diff-test#1 for test