Skip to content

TAX-2677: docs(tax) - Add v3 tax class batch endpoints OpenAPI spec#1301

Merged
bc-vincent-zhao merged 18 commits intomainfrom
tax_classes_v3
Apr 1, 2026
Merged

TAX-2677: docs(tax) - Add v3 tax class batch endpoints OpenAPI spec#1301
bc-vincent-zhao merged 18 commits intomainfrom
tax_classes_v3

Conversation

@bc-vincent-zhao
Copy link
Copy Markdown
Contributor

@bc-vincent-zhao bc-vincent-zhao commented Mar 31, 2026

Jira: TAX-2677

What/Why?

Adds a new OpenAPI 3.0 spec (reference/tax_classes.v3.yaml) documenting the internal v1 Tax API batch endpoints for tax classes (POST /tax/class, PUT /tax/class, DELETE /tax/class).

Key details captured in the spec:

  • Batch size limit: 50 items per request (TaxBatchResourceValidator)
  • Name validation rules: 1–100 chars, case-insensitive uniqueness, disallowed characters
  • DELETE uses id:in query filter; path segment :id is ignored
  • Response envelope follows internal API pattern ({ "data": ..., "meta": ... })
  • 409 on duplicate names, 413 on batch size exceeded, 422 on shape/validation failures

Rollout/Rollback

Documentation-only change — no code deployed. No rollback needed.

Testing

Verify the spec renders correctly in the docs portal and that all three batch endpoints (POST, PUT, DELETE) display with accurate request/response schemas.

Fixes TAX-2677
Co-Authored-By: Claude noreply@anthropic.com

@theromulans
Copy link
Copy Markdown
Contributor

Thanks for this, would be excellent to get our documentation update up and running 👏

@bc-vincent-zhao bc-vincent-zhao marked this pull request as ready for review March 31, 2026 05:22
bc-vincent-zhao and others added 7 commits April 1, 2026 12:41
…batch spec

Rewrite descriptions to be public-facing: remove PHP class names, internal
route details, implementation exception references, and all uses of "internal"
as a label. Port info metadata and security scheme style from v2 spec.

Refs TAX-2677
Co-Authored-By: Claude <noreply@anthropic.com>
Replace internal API host with standard BigCommerce API Gateway server
configuration, matching the pattern used in the v2 tax classes spec.

Refs TAX-2677
Co-Authored-By: Claude <noreply@anthropic.com>
- Rename path /tax/class to /tax/classes
- Rename tag to "Tax Classes" to match conventions used elsewhere
- Remove "Batch" prefix from operation summaries
- Move name character restriction detail to the name field schema description
- Fix uniqueness scope: names must be unique across the store, not just the batch
- Update info description per reviewer suggestion

Refs TAX-2677
Co-Authored-By: Claude <noreply@anthropic.com>
Refs TAX-2677
Co-Authored-By: Claude <noreply@anthropic.com>
Refs TAX-2677
Co-Authored-By: Claude <noreply@anthropic.com>
…X permission

Refs TAX-2677
Co-Authored-By: Claude <noreply@anthropic.com>
Update PUT and DELETE operation summaries to remove "Batch" prefix.
Capitalize "IDs" consistently throughout DELETE endpoint descriptions
and replace "batch" with "request" in uniqueness constraint text.

Refs TAX-2677
Co-Authored-By: Claude <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor Author

@bc-vincent-zhao bc-vincent-zhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @theromulans updated as you recommended.

bc-vincent-zhao and others added 3 commits April 1, 2026 13:52
Capitalize "id" to "ID" in the 422 error description for the batch
update endpoint, consistent with capitalization elsewhere in the spec.

Refs TAX-2677
Co-Authored-By: Claude <noreply@anthropic.com>
Capitalize "ids" to "IDs" in the info description for the DELETE
endpoint for consistent terminology throughout the spec.

Refs TAX-2677
Co-Authored-By: Claude <noreply@anthropic.com>
bc-vincent-zhao and others added 4 commits April 1, 2026 14:09
Co-authored-by: Brett Daniels <theromulans@gmail.com>
Co-authored-by: Brett Daniels <theromulans@gmail.com>
Co-authored-by: Brett Daniels <theromulans@gmail.com>
Co-authored-by: Brett Daniels <theromulans@gmail.com>
bc-vincent-zhao and others added 3 commits April 1, 2026 14:11
Co-authored-by: Brett Daniels <theromulans@gmail.com>
Co-authored-by: Brett Daniels <theromulans@gmail.com>
Co-authored-by: Brett Daniels <theromulans@gmail.com>
Copy link
Copy Markdown
Contributor

@theromulans theromulans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thanks @bc-vincent-zhao !

@bc-vincent-zhao bc-vincent-zhao merged commit 24f580c into main Apr 1, 2026
2 checks passed
@bc-vincent-zhao bc-vincent-zhao deleted the tax_classes_v3 branch April 1, 2026 03:23
@theromulans
Copy link
Copy Markdown
Contributor

@bc-vincent-zhao Is your expectation that these docs should appear online without any further work? Just observing the rollout section doesn't list any further effort and the ticket is closed 👀 Concerned we may have missed part of the ticket's expected outcomes before closing.

@bc-vincent-zhao
Copy link
Copy Markdown
Contributor Author

@theromulans thanks for the reminder, yes, I was expecting the new endpoint automatically appear on dev doc, I may have missed a nav link update, let me double check.

@bc-vincent-zhao
Copy link
Copy Markdown
Contributor Author

@bigcommerce/dev-docs-team would you please help us understand how to get a new endpoint published ? In this PR I created a entire new swagger yml for v3 tax classes endpoint, how can I get it published alongside the current v2 version (https://developer.bigcommerce.com/docs/rest-management/tax/tax-classes) ?

Thanks in advance 🙇

@chris-nowicki
Copy link
Copy Markdown
Contributor

@bigcommerce/dev-docs-team would you please help us understand how to get a new endpoint published ? In this PR I created a entire new swagger yml for v3 tax classes endpoint, how can I get it published alongside the current v2 version (https://developer.bigcommerce.com/docs/rest-management/tax/tax-classes) ?

Thanks in advance 🙇

Hey @bc-vincent-zhao we have officially closed this repository and the dev-center repository. We are in a docs freeze this week while we get ready to go live with the new docs site on Monday the 13th. However, I was able to get your v3 tax classes into the new site that you can preview here :) - https://docs-beta.bigcommerce.com/developer/api-reference/rest/admin/management/tax/tax-classes/get-tax-classes

New Docs Rep is HERE -> https://github.com/bigcommerce/docs-v2
Currently the preview for the new docs site is docs-beta.bigcommerce.com and next monday that will change to docs.bigcommerce.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants