Migrate Sts to Smithy for multi auth + add configurable Sigv4aSignerRegionSet#3793
Open
Migrate Sts to Smithy for multi auth + add configurable Sigv4aSignerRegionSet#3793
Conversation
sbiscigl
approved these changes
Apr 9, 2026
Collaborator
sbiscigl
left a comment
There was a problem hiding this comment.
Looks like the build is failing, otherwise LGTM. If you have time address the comma-delim join re-usable method.
| for (size_t i = 0; i < m_clientConfig->sigV4aSigningRegionSet.size(); ++i) { | ||
| ss << m_clientConfig->sigV4aSigningRegionSet[i]; | ||
| if (i != m_clientConfig->sigV4aSigningRegionSet.size() - 1) { | ||
| ss << ","; |
Collaborator
There was a problem hiding this comment.
oh you need to construct a comma delim list, theres a nice little trick for that using std::accumulate. we do it in other places when we need that.
std::accumulate(std::begin(m_clientConfig->sigV4aSigningRegionSet),
std::end(m_clientConfig->sigV4aSigningRegionSet),
Aws::String{},
[](const Aws::String &acc, const Aws::String &item) -> Aws::String {
const auto value = item;
return acc.empty() ? value : acc + "," + value;
})Might even be worth it to create a StringUtils::Join(...) function that we can use in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
InvokeServiceOperationfor SmithyRestXML codegen (it is not generated in Smithy Headers, and is not generated for SmithyJson clients i.e bedrock); we should enable this correctly for smithy in a separate PRCheck all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.