Move exit status check into ExitWaiter register call#1397
Merged
katiewasnothere merged 1 commit intoapple:mainfrom Apr 7, 2026
Merged
Move exit status check into ExitWaiter register call#1397katiewasnothere merged 1 commit intoapple:mainfrom
katiewasnothere merged 1 commit intoapple:mainfrom
Conversation
katiewasnothere
force-pushed
the
move_exit_check
branch
from
d8da7c7 to
13f7efd
Compare
JaewonHur
reviewed
Apr 6, 2026
Sources/Services/ContainerSandboxService/Server/SandboxService.swift
Outdated
Show resolved
Hide resolved
Sources/Services/ContainerSandboxService/Server/SandboxService.swift
Outdated
Show resolved
Hide resolved
Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
katiewasnothere
force-pushed
the
move_exit_check
branch
from
13f7efd to
7a1cd62
Compare
hajimohammadsamirazizi-lab
approved these changes
Apr 7, 2026
This comment was marked as spam.
This comment was marked as spam.
JaewonHur
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR just simplifies some of the ExitWaiter helper functions on SandboxService by moving the exitStatus check into the ExitWaiter class itself.
Testing