Skip to content

Add Color Progress Output Mode#1384

Merged
jglogan merged 3 commits intoapple:mainfrom
nrthakur:nik/feat/color-progress-output-mode
Apr 10, 2026
Merged

Add Color Progress Output Mode#1384
jglogan merged 3 commits intoapple:mainfrom
nrthakur:nik/feat/color-progress-output-mode

Conversation

@nrthakur
Copy link
Copy Markdown
Contributor

@nrthakur nrthakur commented Apr 3, 2026

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Motivation and Context

Color Progress Output Mode

Adds a color progress output mode (--progress color) that renders ANSI-colored progress output with visual differentiation between progress states.

Unlike the existing ansi mode (which only uses cursor control), color introduces color-coded output:

  • Cyan → spinner / active tasks
  • Bold text → task description
  • Yellow / Green → percentage (in-progress / complete)
  • Green → progress bar
  • Dim text → secondary information

Like ansi mode, this feature requires a TTY.

Closes #1366

Testing

  • Tested locally
  • Added/updated tests
  • Added/updated docs

Visuals

Light Dark Plain Ansi
light.mov
dark.mov
plain.mov
ansi.mov

@nrthakur
Copy link
Copy Markdown
Contributor Author

nrthakur commented Apr 3, 2026

@jglogan PR 2/2 for the Color/Plain Progress Output Mode set (following #1365). I think this is in a good place now would appreciate some eyes when there is a free moment.

-cc @dkovba (since you approved the Plain PR #1367 & have some context)

Thank you both for all the help and support!

p.s - as a Canadian, the way you guys spell colour trips me out 😛

@jglogan jglogan requested a review from dkovba April 3, 2026 22:29
@github-actions github-actions bot added documentation Improvements or additions to documentation cli labels Apr 3, 2026
@jglogan
Copy link
Copy Markdown
Contributor

jglogan commented Apr 3, 2026

the way you guys spell colour trips me out

What is this "colour" you speak of

@jglogan
Copy link
Copy Markdown
Contributor

jglogan commented Apr 3, 2026

make fmt needed (consider installing the pre-commit hook)

Copy link
Copy Markdown
Contributor

@dkovba dkovba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! @jglogan Please check whether the use of colors matches your expectations. Do we expect to use the color mode by default?

@dkovba dkovba requested a review from jglogan April 4, 2026 01:14
@jglogan
Copy link
Copy Markdown
Contributor

jglogan commented Apr 9, 2026

@nrthakur Could you have a look at Dmitry's feedback when you get a chance? And regarding the color, would it be possible to post a couple of representative screenshots, one with a dark-on-light terminal, and one light-on-dark?

@dkovba

Do we expect to use the color mode by default?

I'd expect the default to be plain output still, and that we'd want a follow-on issue for a feature to allow the user to override the default mode, and eventually override the color palette. As we're transitioning away from macOS user defaults to config files and environment variables for this, I'd expect we'd want an environment variable like CONTAINER_CLI_PROGRESS or something of that nature.

@nrthakur
Copy link
Copy Markdown
Contributor Author

nrthakur commented Apr 9, 2026

@jglogan @dkovba

Apologies, it's final exam season right now didn't mean to drop this. Will have a commit addressing reviews sometime before EOD today / early tomorrow.

Thank you both!

@nrthakur
Copy link
Copy Markdown
Contributor Author

nrthakur commented Apr 9, 2026

@jglogan @dkovba Reviews addressed, please see PR description for visuals.

Created #1406 as a follow-on for CONTAINER_CLI_PROGRESS environment variable support. Would love to pick it up once this PR is merged.

@nrthakur nrthakur requested a review from dkovba April 9, 2026 17:34
@jglogan
Copy link
Copy Markdown
Contributor

jglogan commented Apr 9, 2026

Apologies, it's final exam season right now

No need for apologies, we appreciate what you're doing and the time you're giving to the project.

Go crush your exams!

@jglogan jglogan merged commit 1c37384 into apple:main Apr 10, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: Add color progress mode

3 participants