Conversation
|
@jglogan PR 2/2 for the Color/Plain Progress Output Mode set (following #1365). I think this is in a good place now would appreciate some eyes when there is a free moment. -cc @dkovba (since you approved the Plain PR #1367 & have some context) Thank you both for all the help and support! p.s - as a Canadian, the way you guys spell colour trips me out 😛 |
What is this "colour" you speak of |
|
|
|
@nrthakur Could you have a look at Dmitry's feedback when you get a chance? And regarding the color, would it be possible to post a couple of representative screenshots, one with a dark-on-light terminal, and one light-on-dark?
I'd expect the default to be plain output still, and that we'd want a follow-on issue for a feature to allow the user to override the default mode, and eventually override the color palette. As we're transitioning away from macOS user defaults to config files and environment variables for this, I'd expect we'd want an environment variable like |
No need for apologies, we appreciate what you're doing and the time you're giving to the project. Go crush your exams! |
Type of Change
Motivation and Context
Color Progress Output Mode
Adds a color progress output mode (
--progress color) that renders ANSI-colored progress output with visual differentiation between progress states.Unlike the existing
ansimode (which only uses cursor control),colorintroduces color-coded output:Like
ansimode, this feature requires a TTY.Closes #1366
Testing
Visuals
light.mov
dark.mov
plain.mov
ansi.mov