Move schema validation to tool-call command only#155
Open
Conversation
Schema validation via --schema/--schema-mode was a global option used by tools-call, tools-get, and prompts-get. This was confusing — narrow the scope to tools-call only, where it's most useful for CI/script validation. https://claude.ai/code/session_012EqvtRBWtSQHn25i68cRiN
tools-get is a natural place to validate a tool schema hasn't changed without side effects, so keep --schema/--schema-mode there too. https://claude.ai/code/session_012EqvtRBWtSQHn25i68cRiN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes schema validation from the global CLI options and the
tools-getandprompts-getcommands, moving it exclusively to thetools-callcommand where it's most useful for validating arguments before execution.Key Changes
--schemaand--schema-modeoptions from the top-level CLI program and session program, making them command-specific instead--schemaand--schema-modeoptions totools-callcommand with dedicated help text explaining their purposegetTool()andgetPrompt()commands - these commands no longer validate schemastools.tsandprompts.tscommand files--schemaand--schema-modefrom global options to subcommand-specific options, removing validation for schema file existence and mode values at parse timetools-getandprompts-getcommandstools-callImplementation Details
tools-call --schema, not when listing or getting tool/prompt definitions--schemaand--schema-modeoptions are now parsed as subcommand-specific options rather than global options--schema-modevalues from the parser, allowing these to be validated at command execution time if needed--schemais for validating tool schemas before calling themhttps://claude.ai/code/session_012EqvtRBWtSQHn25i68cRiN