[Web][Experimental] Add support for cross-origin storage caching#18893
[Web][Experimental] Add support for cross-origin storage caching#18893akaashrp wants to merge 2 commits intoapache:mainfrom
Conversation
akaashrp
commented
Mar 10, 2026
- Add support for cross-origin storage caching
- Bump version to 0.24.0-dev2
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces experimental support for cross-origin storage caching, enhancing the web runtime's ability to store and retrieve data efficiently across different origins. This feature aims to improve performance by leveraging a new browser API for shared storage. The existing caching infrastructure has been refactored to accommodate this new cache type, providing a unified interface for managing various storage backends and improving flexibility in cache configuration. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds support for a new experimental cross-origin storage caching mechanism, introducing ArtifactCrossOriginStorageCache and refactoring public API functions like hasTensorInCache, deleteTensorCache, and fetchTensorCache for a more extensible options-based configuration. However, the current implementation of the hash cache uses a globally accessible Map on globalThis, which can lead to the leakage of sensitive information such as private repository tokens and content hashes to other scripts on the same origin. While the overall API design is improved, there is a suggestion to simplify some of the new logic in fetchTensorCache.
|
cc @tqchen for review |