[WIP][SPARK-55805] fixed ignore type override for linter in _SimpleStreamReaderWrapper#54791
Open
sreeraj234 wants to merge 2 commits intoapache:masterfrom
Open
[WIP][SPARK-55805] fixed ignore type override for linter in _SimpleStreamReaderWrapper#54791sreeraj234 wants to merge 2 commits intoapache:masterfrom
sreeraj234 wants to merge 2 commits intoapache:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a type override lint suppression in _SimpleStreamReaderWrapper.read() by renaming the parameter from input_partition to partition to match the parent class DataSourceStreamReader.read() signature.
Changes:
- Renamed
input_partitionparameter topartitionin_SimpleStreamReaderWrapper.read()to match parent class, removing the# type: ignore[override]comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
sreeraj234
force-pushed
the
fix_type_error
branch
from
39bac2d to
56f6e07
Compare
sreeraj234
force-pushed
the
fix_type_error
branch
2 times, most recently
from
c1f4a16 to
27cf09d
Compare
…treamReaderWrapper.read
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
fixed ignore type override for linter in _SimpleStreamReaderWrapper. Made the function signature match the parent class.
Why are the changes needed?
We have some ignores that are not necessary for data source writers.
Does this PR introduce any user-facing change?
No
How was this patch tested?
CI
Was this patch authored or co-authored using generative AI tooling?
No