HDDS-14831. Datanode should gracefully handle CONTAINER_ALREADY_EXISTS#9925
Open
weimingdiit wants to merge 1 commit intoapache:masterfrom
Open
HDDS-14831. Datanode should gracefully handle CONTAINER_ALREADY_EXISTS#9925weimingdiit wants to merge 1 commit intoapache:masterfrom
weimingdiit wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
Hi,@jojochuang @adoroszlai @aajisaka could you please take a look at this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add CONTAINER_ALREADY_EXISTS to HddsDispatcher#canIgnoreException.
Create-container requests may fail with CONTAINER_ALREADY_EXISTS before a container instance is available. In that case, the dispatcher can still enter the generic failure path and try to mark the container unhealthy, which may result in an unexpected NPE.
Treating CONTAINER_ALREADY_EXISTS as an ignorable result avoids that path and lets the request fail gracefully with normal logging.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14831