Improve startup cache loading performance#9307
Draft
mbien wants to merge 1 commit intoapache:masterfrom
Draft
Conversation
mbien
added
Code cleanup
- use Data*Streams instead of Object*Streams - simplify file format (no XML) - code renovation and minor smaller optimizations result are 3-4x faster cache load times (readCache() and calculateParents() methods) minor: - List -> Set for field solely used for contains() in inner loop
mbien
force-pushed
the
cache-loading-perf
branch
from
0047b0a to
34d1d39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data*Streamsinstead ofObject*Streamsresult are about 3-4x faster cache loading times
minor:
List->Setfor field solely used for contains() in inner loopThreadDeathas part of the cleanupsee the
readCache()andcalculateParents()marked in purplebefore:
after:
third PR for some more startup optimizations pending. (first was #9303)