[GITHUB-6925] Fixing debugger tests.

[lahodaj]

It is my understanding failing tests for java/debugger.jpda.truffle may become an impediment to adopt JDK 21. So, this is an attempt to show a possible direction to fix the debugger.jpda.truffle tests. Instead of running the GraalVM launcher (which no longer exists), run java with the appropriate launcher class.

This patch currently only fixes JS, as that's what we already have/bundle. Hopefully support for R/Python/Ruby could be added, by downloading the appropriate libraries (if they exist) and adding the to the runtime classpath. I didn't try myself, though. Please feel free to enhance the patch.

A good property is that the tests no longer require the GraalVM, but can run on any supported JDK.

I did not (yet?) do updates to the GraalVM ${{ matrix.graal }} Tests GitHub Actions job. Should this be moved to GraalVM 21?

Please let me know what you think.

/cc @mbien , @JaroslavTulach

---

^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

• are all your own work, and you have the right to contribute them.
• are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

1. Was this PR correctly labeled, did the right tests run? When did they run?
2. Is this PR squashed?
3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

[mbien]

Good idea with using the already existing js wrapper module. This would allow to keep some tests enabled.

I did not (yet?) do updates to the GraalVM ${{ matrix.graal }} Tests GitHub Actions job. Should this be moved to GraalVM 21?

Exactly that would be great. Those two sections would need adjusting.

netbeans/.github/workflows/main.yml

Lines 2563 to 2565 in 26a05a6

	# TODO uses GraalVM 17 / 22.3.1 which is the last known release which offers all required language extensions
	# GraalVM based on JDK 21+ doesn't support the 'gu' tool anymore - extensions are now regular application dependencies
	graal: [ '22.3.1' ]

netbeans/.github/workflows/main.yml

Lines 2582 to 2590 in 26a05a6

	- name: Setup GraalVM ${{ matrix.graal }}
	run: |
	URL=https://github.com/graalvm/graalvm-ce-builds/releases/download/vm-${{ matrix.graal }}/graalvm-ce-java17-linux-amd64-${{ matrix.graal }}.tar.gz
	curl -L $URL | tar -xz
	GRAALVM=`pwd`/graalvm-ce-java17-${{ matrix.graal }}
	echo "JAVA_HOME=$GRAALVM" >> $GITHUB_ENV
	- name: Setup GraalVM Languages (python, R, ruby and js)
	run: $JAVA_HOME/bin/gu install --no-progress python R ruby js

the "Setup GraalVM Languages" step can be removed I suppose and the URL/filename might need an update now.

[jtulach]

A good property is that the tests no longer require the GraalVM, but can run on any supported JDK.

Right, there is no need to run on GraalVM anymore! Testing debugging capabilities of debugger.jpda.truffle should be possible on OpenJDK21+

Instead of running the GraalVM launcher (which no longer exists), run java with the appropriate launcher class.

Yes, that sounds like the right approach.

This patch currently only fixes JS, as that's what we already have/bundle. Hopefully support for R/Python/Ruby could be added

• R is being abandoned as far as I know.
• Ruby isn't that much maintained either.
• Python is still actively supported by GraalVM guys, but:
• the debugger.jpda.truffle support is generic
• getting it run for JavaScript should be enough to verify it works
• thanks Jan for getting the tests running at all!
  • few times I wanted to do some refactorings of the code ...
  • but I always gave up due to non-functional tests

[jtulach]

+1, I am really glad to see the tests being run regularly!

[jtulach]

Graal.js is packaged as NetBeans module, so reusing it is a great idea.

[jtulach]

Huge simplification by deleting a lot of code. Good work!