Adjust GlassFish plugin for changes in GlassFish 7.1#9297
Merged
matthiasblaesing merged 1 commit intoapache:masterfrom Mar 26, 2026
Merged
Adjust GlassFish plugin for changes in GlassFish 7.1#9297matthiasblaesing merged 1 commit intoapache:masterfrom
matthiasblaesing merged 1 commit intoapache:masterfrom
Conversation
Contributor
matthiasblaesing
left a comment
matthiasblaesing
left a comment
There was a problem hiding this comment.
Only eyeballed this, but looks generally sane. The core change makes sense (the module path addition). Where I'm less sure about is the implementation of the jvmOptions. The moment spaces are part of the options this will break in strange ways.
enterprise/glassfish.common/src/org/netbeans/modules/glassfish/common/StartTask.java
Outdated
Show resolved
Hide resolved
OndroMih
force-pushed
the
ondromih-glassfish71
branch
from
553340e to
fb885e5
Compare
matthiasblaesing
approved these changes
Mar 26, 2026
Contributor
matthiasblaesing
left a comment
matthiasblaesing
left a comment
There was a problem hiding this comment.
Thanks for the update. Looks sane to me. A very quick smoketest (starting GF8) worked as it should.
I cleared the CI/CD run. If that comes back green, I intent to merge shortly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The launcher mechanism of GlassFish changed in 7.1. It's supposed to be an internal feature while it's recommended launching GlassFish using scripts in bin directory (e.g. bin/asadmin).
This PR doesn't do that, it just adjust the current launching mechanism in Netbeans to adapt to GlassFish 7.1+ - define modulepath and add modules.
It also adds "Additional JVM Options" field in case it's needed to adjust the launchers options if needed, e.g. if something will change again in GlassFish launcher.