Document hashCode/equals stability requirement for InstanceContent and Lookup#9291
Open
hxreborn wants to merge 1 commit intoapache:masterfrom
Open
Document hashCode/equals stability requirement for InstanceContent and Lookup#9291hxreborn wants to merge 1 commit intoapache:masterfrom
hxreborn wants to merge 1 commit intoapache:masterfrom
Conversation
Objects with mutable hashCode/equals can cause silent removal failures in AbstractLookup when storage switches to hash-based InheritanceTree. Document the constraint, matching the general contract of HashMap. Closes apache#9270
neilcsmith-net
added
Platform
neilcsmith-net
approved these changes
Mar 29, 2026
Member
neilcsmith-net
left a comment
neilcsmith-net
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added javadoc notes to InstanceContent and Lookup about hashCode/equals stability. Same contract as HashMap/HashSet, just wasn't called out.
Closes #9270