Skip to content

Support aggregation push-down optimize for table view of non aligned series#17294

Open
Wei-hao-Li wants to merge 11 commits intomasterfrom
optimizeLast
Open

Support aggregation push-down optimize for table view of non aligned series#17294
Wei-hao-Li wants to merge 11 commits intomasterfrom
optimizeLast

Conversation

@Wei-hao-Li
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 52.08333% with 161 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.74%. Comparing base (964f517) to head (19f7058).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...eeNonAlignedDeviceViewAggregationScanOperator.java 0.00% 84 Missing ⚠️
...eryengine/plan/planner/TableOperatorGenerator.java 4.65% 41 Missing ⚠️
...nner/distribute/TableDistributedPlanGenerator.java 94.15% 10 Missing ⚠️
...node/AlignedAggregationTreeDeviceViewScanNode.java 30.00% 7 Missing ⚠️
...e/NonAlignedAggregationTreeDeviceViewScanNode.java 30.00% 7 Missing ⚠️
...ource/relational/AbstractAggTableScanOperator.java 0.00% 5 Missing ⚠️
...lanner/node/AggregationTreeDeviceViewScanNode.java 0.00% 4 Missing ⚠️
...eryengine/plan/planner/plan/node/PlanNodeType.java 60.00% 2 Missing ⚠️
.../source/relational/DeviceIteratorScanOperator.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #17294      +/-   ##
============================================
- Coverage     39.76%   39.74%   -0.02%     
  Complexity      282      282              
============================================
  Files          5100     5102       +2     
  Lines        342121   342535     +414     
  Branches      43593    43646      +53     
============================================
+ Hits         136034   136155     +121     
- Misses       206087   206380     +293     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Weihao Li <18110526956@163.com>
Signed-off-by: Weihao Li <18110526956@163.com>
Signed-off-by: Weihao Li <18110526956@163.com>
Signed-off-by: Weihao Li <18110526956@163.com>
Signed-off-by: Weihao Li <18110526956@163.com>
Signed-off-by: Weihao Li <18110526956@163.com>
Signed-off-by: Weihao Li <18110526956@163.com>
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

}

@Override
public long ramBytesUsed() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The estimation includes child and dataSourceOperators but doesn't include the childOperatorGenerator, which may hold references to the operator tree templates. Minor memory accounting concern.

@Override
public Operator visitAggregationTreeDeviceViewScan(
AggregationTreeDeviceViewScanNode node, LocalExecutionPlanContext context) {
public Operator visitAlignedAggregationTreeDeviceViewScan(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add visitAggregationTreeDeviceViewScanNode method and directly throw UnsupportedException for that, avoiding AggregationTreeDeviceViewScanNode visit its super class AggregationTableScanNode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants