HIVE-29495: [HPLSQL]Setting hive configs in hplsql causing console logs to be lost#6361
Open
mdayakar wants to merge 1 commit intoapache:masterfrom
Open
HIVE-29495: [HPLSQL]Setting hive configs in hplsql causing console logs to be lost#6361mdayakar wants to merge 1 commit intoapache:masterfrom
mdayakar wants to merge 1 commit intoapache:masterfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HIVE-29495: [HPLSQL]Setting hive configs in hplsql causing console logs to be lost.
What changes were proposed in this pull request?
When SET hive config is executed, it is executed as a separate HiveCommand which is registrering a new logging context so it is creating a new operation log and after executing SET hive config it is unregistering the logging context which closes the operation log so for all the statements executed after this are not getting logged into operation log so in beeline console nothing is getting showed. Now we are not registering logging context as a part of SET hive config statement, which results in logging into the existing operation log so the logs are coming for all statements executed.
Why are the changes needed?
Without fix, after executing SET hive config there will not be any console logs on the beeline console.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Testcase (testPrintMessageAfterExecuteSetHiveConfig) is added in the TestHplSqlViaBeeLine class
mvn test -Dtest=TestHplSqlViaBeeLine#testPrintMessageAfterExecuteSetHiveConfig -pl itests/hive-unit -Pitests