[fix](storage) avoid duplicate exported compaction metrics#61420
Open
CSoulode wants to merge 3 commits intoapache:masterfrom
Open
[fix](storage) avoid duplicate exported compaction metrics#61420CSoulode wants to merge 3 commits intoapache:masterfrom
CSoulode wants to merge 3 commits intoapache:masterfrom
Conversation
issue: apache#60791 Add missing labels for compaction task state and compaction io metrics to avoid duplicate Prometheus time series.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Author
|
run buildall |
TPC-H: Total hot run time: 26810 ms |
TPC-DS: Total hot run time: 167912 ms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: #60791
Add missing labels for compaction task state and compaction io metrics to avoid duplicate Prometheus time series.
What problem does this PR solve?
Issue Number: close #60791
Related PR: #N/A
Problem Summary:
This PR fixes duplicate Prometheus time series exported by BE compaction metrics.
Although issue #60791 was reported in compute-storage decoupled mode, the root cause is not specific to cloud mode itself. The duplicate series come from shared BE metric definitions/export semantics, where multiple internal metrics were exported with the same metric name and the same label set.
Release note
None
Check List (For Author)
Manual test:
curl -X POST "http://$BE_HOST:$BE_HTTP/api/compaction/run?tablet_id=$TABLET_ID&compact_type=cumulative"Before:
After:
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)