Skip to content

Add datafusion/arrow_canonical_extension_types feature#20908

Open
Tpt wants to merge 1 commit intoapache:mainfrom
Tpt:patch-1
Open

Add datafusion/arrow_canonical_extension_types feature#20908
Tpt wants to merge 1 commit intoapache:mainfrom
Tpt:patch-1

Conversation

@Tpt
Copy link
Contributor

@Tpt Tpt commented Mar 12, 2026

Wraps parquet/arrow_canonical_extension_types and arrow-schema/canonical_extension_types

This feature is enabled by default (arrow-schema/canonical_extension_types was enabled by default)

It might be a good flag to hide behind support for canonical extension types in various DataFusion operators

@github-actions github-actions bot added the core Core DataFusion crate label Mar 12, 2026
@Tpt Tpt marked this pull request as ready for review March 12, 2026 14:51
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Tpt

object_store = { workspace = true }
parking_lot = { workspace = true }
parquet = { workspace = true, optional = true, default-features = true }
parquet = { workspace = true, optional = true, default-features = true, features = ["arrow_canonical_extension_types"] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we make this a feature of DataFusion?

I also think it might be a good idea to show how to use these canonical types in DataFusion (maybe with an example)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I have updated the MR to make it a feature.

I have only added a test. For an example I guess a good approach might be to import a part of https://github.com/timsaucer/datafusion_extension_type_examples

@timsaucer what do you think about it?

@Tpt Tpt changed the title Core: make sure to enable extension type support in Parquet Add datafusion/arrow_canonical_extension_types feature Mar 13, 2026
@github-actions github-actions bot added the development-process Related to development process of DataFusion label Mar 13, 2026
Wraps `parquet/arrow_canonical_extension_types` and `arrow-schema/canonical_extension_types`

This feature is enabled by default (`arrow-schema/canonical_extension_types` was enabled by default)

It might be a good flag to hide behind support for canonical extension types in various DataFusion operators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate development-process Related to development process of DataFusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants