Skip to content

Fix #37833: Use named logger instead of root logger in transforms/util.py #37857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liferoad wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −8
Open

Fix #37833: Use named logger instead of root logger in transforms/util.py #37857

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions sdks/python/apache_beam/transforms/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@
if TYPE_CHECKING:
from apache_beam.runners.pipeline_context import PipelineContext

_LOGGER = logging.getLogger(__name__)

__all__ = [
'BatchElements',
'CoGroupByKey',
Expand Down Expand Up @@ -499,7 +501,7 @@ def get_secret_bytes(self) -> bytes:
request={"name": secret_version_path})
return response.payload.data
except api_exceptions.NotFound:
logging.info(
_LOGGER.info(
"Secret version %s not found. "
"Creating new secret and version.",
secret_version_path)
Expand Down Expand Up @@ -704,7 +706,7 @@ def expand(self, pcoll):
try:
coder = coder.as_deterministic_coder(self.label)
except ValueError:
logging.warning(
_LOGGER.warning(
'GroupByEncryptedKey %s: '
'The key coder is not deterministic. This may result in incorrect '
'pipeline output. This can be fixed by adding a type hint to the '
Expand Down Expand Up @@ -1025,7 +1027,7 @@ def finish_bundle(self):
self._batch = None
self._running_batch_size = 0
self._target_batch_size = self._batch_size_estimator.next_batch_size()
logging.info(
_LOGGER.info(
"BatchElements statistics: " + self._batch_size_estimator.stats())


Expand Down Expand Up @@ -1957,15 +1959,15 @@ def process(
log_line += ', pane_info=' + repr(pane_info)

if self.level == logging.DEBUG:
logging.debug(log_line)
_LOGGER.debug(log_line)
elif self.level == logging.INFO:
logging.info(log_line)
_LOGGER.info(log_line)
elif self.level == logging.WARNING:
logging.warning(log_line)
_LOGGER.warning(log_line)
elif self.level == logging.ERROR:
logging.error(log_line)
_LOGGER.error(log_line)
elif self.level == logging.CRITICAL:
logging.critical(log_line)
_LOGGER.critical(log_line)
else:
print(log_line)

Expand Down
Loading