[AURON #2090] Convert CoalesceExec to native implementation#2124
Open
guixiaowen wants to merge 1 commit intoapache:masterfrom
Open
[AURON #2090] Convert CoalesceExec to native implementation#2124guixiaowen wants to merge 1 commit intoapache:masterfrom
guixiaowen wants to merge 1 commit intoapache:masterfrom
Conversation
cxzl25
changed the title
| .withKey("auron.enable.coalesce") | ||
| .withCategory("Operator Supports") | ||
| .withDescription("Enable CoalesceExec operation conversion to native Auron implementations.") | ||
| .withDefaultValue(true); |
Contributor
There was a problem hiding this comment.
nit: needs a new line here
spark-extension/src/main/java/org/apache/auron/spark/configuration/SparkAuronConfiguration.java
Show resolved
Hide resolved
spark-extension/src/main/scala/org/apache/spark/sql/auron/AuronConverters.scala
Show resolved
Hide resolved
| child.execute() | ||
| } | ||
|
|
||
| val partitions: Array[Partition] = { |
Contributor
There was a problem hiding this comment.
Should this be a lazy val instead for lazy computation. The way it is set up right now, I think it will try to compute this eagerly during planning.
spark-extension-shims-spark/src/main/scala/org/apache/spark/sql/auron/ShimsImpl.scala
Show resolved
Hide resolved
| class AuronNativeCoalesceExecSuite extends AuronQueryTest with BaseAuronSQLSuite { | ||
| import testImplicits._ | ||
|
|
||
| test("test CoalesceExec to native") { |
Contributor
There was a problem hiding this comment.
We should improve the testing here, some cases I can think about
- numPartitions > inputPartitions (no-op or expansion)
- numPartitions = 1, numPartitions = 0
- empty dataset
guixiaowen
force-pushed
the
convertCoalesceExec
branch
from
1532596 to
a047144
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2090
Rationale for this change
Convert CoalesceExec to native.
What changes are included in this PR?
Are there any user-facing changes?
How was this patch tested?
UT