Fix newline rendering in DAG warning alert UI#63588
Open
wjddn279 wants to merge 1 commit intoapache:mainfrom
Open
Fix newline rendering in DAG warning alert UI#63588wjddn279 wants to merge 1 commit intoapache:mainfrom
wjddn279 wants to merge 1 commit intoapache:mainfrom
Conversation
wjddn279
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
shivaam
reviewed
Mar 14, 2026
| return ( | ||
| <Alert data-testid="warning-alert" status="warning"> | ||
| <Flex align="center">{warning?.message}</Flex> | ||
| <Flex align="center" whiteSpace="pre-wrap"> |
Contributor
There was a problem hiding this comment.
Nit: ErrorAlert uses whiteSpace="preserve" with wordBreak, while this uses pre-wrap.
Both work, but might be worth aligning them for consistency since they render side by side in the same modal. They are both used together in the DAGWarningsModal.tsx file.
Not a blocker though.
shivaam
approved these changes
Mar 14, 2026
Contributor
shivaam
left a comment
shivaam
left a comment
There was a problem hiding this comment.
Left a minor nit on whitespace consistency with ErrorAlert, but overall LGTM. Clean fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: #59430
Description
Fixes an issue where newlines (\n) in the message field of the DAG warning API were not being rendered as line breaks in the UI.
UI
ASIS
TOBE
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.