Fix auto-triage user_confirm accepting unrecognized keys as default answer#63579
Open
choo121600 wants to merge 1 commit intoapache:mainfrom
Open
Fix auto-triage user_confirm accepting unrecognized keys as default answer#63579choo121600 wants to merge 1 commit intoapache:mainfrom
choo121600 wants to merge 1 commit intoapache:mainfrom
Conversation
choo121600
requested review from
amoghrajesh,
ashb,
bugraoz93,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
jscheffl and
potiuk
as code owners
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
jscheffl
approved these changes
Mar 14, 2026
bugraoz93
approved these changes
Mar 14, 2026
| if quit_allowed: | ||
| return Answer.QUIT | ||
| sys.exit(1) | ||
| while True: |
Contributor
There was a problem hiding this comment.
Couldn't we do it without while True? Maybe a flag approach
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During
breeze pr auto-triage, when approving workflow runs,user_confirmsilently treats unrecognized keys as the default answer.Since the approval prompt defaults to YES (when no sensitive changes are detected), pressing a wrong key unintentionally approves workflow runs.
Change
user_confirmto re-prompt on unrecognized input instead of falling through to the default.Before
After
Was generative AI tooling used to co-author this PR?
claude opus 4.6
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.