Added statement timeout support in SnowflakeSqlApiHook & Operator#63575
Open
justinpakzad wants to merge 1 commit intoapache:mainfrom
Open
Added statement timeout support in SnowflakeSqlApiHook & Operator#63575justinpakzad wants to merge 1 commit intoapache:mainfrom
justinpakzad wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
|
Thanks for your PR! While reviewing this, I thought of a couple of edge cases regarding the
Should we add some validation logic to raise a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for statement-level timeout in the
SnowflakeSqlApiHook()andSnowflakeSqlApiOperator(). Default value is set to None and it's only included in the request if provided. As per the docs - if timeout is not provided it will fall back to the STATEMENT_TIMEOUT_IN_SECONDS parameter.I tested this against my actual Snowflake account and it's working as expected. Also included an additional unit test for the hook.
closes: #60894
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.