Removes coordinator cancel RPC#6243
Merged
keith-turner merged 3 commits intoapache:mainfrom Mar 25, 2026
Merged
Conversation
Modified the command that calls this to instead reach out directly to the compactor. This change is made in support of apache#6217, it removes a useage of the running cahce and it simplifies the coordinators RPCs.
dlmarion
reviewed
Mar 25, 2026
| System.out.println("Cancel sent to coordinator for " + ecid); | ||
|
|
||
| try (var tablets = | ||
| context.getAmple().readTablets().forLevel(Ample.DataLevel.USER).fetch(ECOMP).build()) { |
Contributor
There was a problem hiding this comment.
Might be useful to put this code that gets the ecomp information from the metadata table into a method in ExternalCompactionUtil. There is a method called getRunningCompactions on the Coordinator. You could use this new method in its place when you remove the RunningCache.
Contributor
Author
There was a problem hiding this comment.
Moved the code into ExternalCompactionUtil
dlmarion
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified the command that calls this to instead reach out directly to the compactor. This change is made in support of #6217, it removes a useage of the running cahce and it simplifies the coordinators RPCs.