Removed RunningCompactionsSummary object from Monitor#6235
Merged
dlmarion merged 5 commits intoapache:mainfrom Mar 25, 2026
Merged
Removed RunningCompactionsSummary object from Monitor#6235dlmarion merged 5 commits intoapache:mainfrom
dlmarion merged 5 commits intoapache:mainfrom
Conversation
This change removes the RunningCompactionsSummary in favor of just returning a list of RunningCompactionInfo. The long running compaction map was also modified to use the RunningCompactionInfo instead of the TExternalCompaction object to reduce the computation needed at request time to return the results. Closes apache#6234
DomGarguilo
reviewed
Mar 25, 2026
| @@ -65,6 +66,7 @@ public RunningCompactionInfo(TExternalCompaction ec) { | |||
| var updates = requireNonNull(ec.getUpdates(), "Missing Thrift external compaction updates"); | |||
Member
There was a problem hiding this comment.
I think we might need to treat tec.getUpdates() == null as an empty map here now that we are constructing the RunningCompactionInfo during the collection phase in SystemInformation (.add(new RunningCompactionInfo(tec));) instead of creating that RunningCompactionInfo later when that endpoint is used. I think the TExternalCompaction may exist without an update for a short period so we should probably handle that instead of throwing a NPE.
Contributor
Author
There was a problem hiding this comment.
I think the TExternalCompaction may exist without an update for a short period so we should probably handle that instead of throwing a NPE.
I think that's correct. I'll update.
DomGarguilo
reviewed
Mar 25, 2026
core/src/main/java/org/apache/accumulo/core/util/compaction/RunningCompactionInfo.java
Show resolved
Hide resolved
This reverts commit bc14cea.
DomGarguilo
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes the RunningCompactionsSummary in favor of just returning a list of RunningCompactionInfo. The long running compaction map was also modified to use the RunningCompactionInfo instead of the TExternalCompaction object to reduce the computation needed at request time to return the results.
Closes #6234