fix(bundler): rewrite namespace re-exports for Bun bundler compatibility#18524
Open
sjawhar wants to merge 1 commit intoanomalyco:devfrom
Open
fix(bundler): rewrite namespace re-exports for Bun bundler compatibility#18524sjawhar wants to merge 1 commit intoanomalyco:devfrom
sjawhar wants to merge 1 commit intoanomalyco:devfrom
Conversation
Bun's bundler emits self-referential assignments (X.Y = X.Y) for namespace re-exports that resolve to undefined when the source module hasn't finished initializing. Replace fragile namespace re-export pattern with concrete object exports + separate type-only namespaces in 9 index/facade files.
github-actions
bot
added
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
bot
removed
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #18525
Type of change
What does this PR do?
Rewrites 9 facade/index files that re-export values from service modules inside TypeScript namespaces. Bun's bundler transpiles namespace re-exports like
export const FileDiff = S.FileDiffinto self-referential assignments (Snapshot.FileDiff = Snapshot.FileDiff) which evaluate toundefinedwhen circular imports delay module initialization.The fix splits each file into:
export const X = { ... }object literal with value exports (eagerly initialized with correct references)export namespace X { ... }block with type-only exports (erased at runtime)This preserves the identical public API surface while ensuring Bun's bundler emits correct initialization code regardless of module evaluation order.
Files changed:
src/snapshot/index.ts,src/question/index.ts,src/provider/auth.ts,src/file/index.ts,src/file/time.ts,src/skill/skill.ts,src/tool/truncate.ts,src/permission/index.ts,src/format/index.tsHow did you verify your code works?
bun typecheck— passes clean (tsgo --noEmit)bun run build --single— builds successfullyopencode serve— starts and listens without TypeError (previously crashed withSnapshot2.FileDiff.arrayandProviderAuth2.Authorization.optionalerrors)opencode run "echo test"— creates session, runs LLM prompt loop, executes tools successfullyScreenshots / recordings
N/A — not a UI change.
Checklist