Skip to content

Media: Fix strpos() check and file_get_contents() handling in wp_get_…#11237

Closed
tejas0306 wants to merge 1 commit intoWordPress:trunkfrom
tejas0306:fix-image-alttext-strpos
Closed

Media: Fix strpos() check and file_get_contents() handling in wp_get_…#11237
tejas0306 wants to merge 1 commit intoWordPress:trunkfrom
tejas0306:fix-image-alttext-strpos

Conversation

@tejas0306
Copy link

Fixes https://core.trac.wordpress.org/ticket/64849#ticket

Summary

The wp_get_image_alttext() function in src/wp-admin/includes/image.php checks for XMP metadata using strpos(), but the current implementation uses a loose comparison:

if ( ! $xmp_start || ! $xmp_end ) {
    return $alt_text;
}

…image_alttext().

Use strict comparison for strpos() to avoid treating position 0 as false, and add a guard for file_get_contents() returning false.  Props suhan2411. Fixes #64849"
@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props suhan2411.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@github-actions
Copy link

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 62027
GitHub commit: 6dac3b4

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions bot closed this Mar 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants