Media: Fix strpos() check and file_get_contents() handling in wp_get_…#11237
Media: Fix strpos() check and file_get_contents() handling in wp_get_…#11237tejas0306 wants to merge 1 commit intoWordPress:trunkfrom
Conversation
…image_alttext(). Use strict comparison for strpos() to avoid treating position 0 as false, and add a guard for file_get_contents() returning false. Props suhan2411. Fixes #64849"
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Fixes https://core.trac.wordpress.org/ticket/64849#ticket
Summary
The
wp_get_image_alttext()function insrc/wp-admin/includes/image.phpchecks for XMP metadata usingstrpos(), but the current implementation uses a loose comparison: