admin-ui / Breadcrumbs: stricter items[].to prop types#76493
Open
admin-ui / Breadcrumbs: stricter items[].to prop types#76493
items[].to prop types#76493Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
|
cc @CGastrell |
ciampo
added
[Type] Enhancement
|
Size Change: 0 B Total Size: 8.75 MB ℹ️ View Unchanged
|
ciampo
changed the title
items[].to prop
ciampo
changed the title
items[].to propitems[].to prop types
ciampo
force-pushed
the
feat/admin-ui-breadcrumb-types
branch
from
63a5d94 to
ff216bd
Compare
Contributor
|
Worked well on my end, trying to add an item without First item without Adding these lines to the Breadcrumbs component (green margin) seem well scoped: And produces this: So, even with a failing item, the UI doesn't break. Unsure this is something we want to consider, I just think of prioritizing a UI that doesn't break. I'll leave it for your consideration. Other than that, I have no authority here to approve the PR, but it works well. |
ciampo
force-pushed
the
feat/admin-ui-breadcrumb-types
branch
from
ff216bd to
709c2d2
Compare
Contributor
Author
|
The TS error should already be a strong indication (and should ideally prevent the build from completing).
Most of those lines should be redundant, since the Apart from that, fixing styles would not remove the main semantics issue (two or more |
Contributor
Author
|
Separately, I believe
Not sure who owns this, but cc @WordPress/gutenberg-components @WordPress/gutenberg-design |
|
Flaky tests detected in b4cf231. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23089135341
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Related to #76467
Tighten types in admin-ui's
Breadcrumbscomponent to clarify expectations around all items (apart from the last one) to have to specify atopropWhy?
Current types don't specify that requirement, and it's possible to render multiple
<h1>breadcrumb items — which is wrong semantically and breaks the layoutHow?
h1when it has notopropTesting Instructions
Breadcrumbswithout settingtoto one of the (non-last) items — a TS error should be flagged