Update minimum CMake version to 3.10 in wabt-config.cmake#2714
Merged
sbc100 merged 1 commit intoWebAssembly:mainfrom Mar 11, 2026
Merged
Update minimum CMake version to 3.10 in wabt-config.cmake#2714sbc100 merged 1 commit intoWebAssembly:mainfrom
sbc100 merged 1 commit intoWebAssembly:mainfrom
Conversation
CMake versions 3.31 and newer have begun to warn that compatibility with CMake versions older than 3.10 will be removed. When that happens, this will stop working. See the 3.31 release notes: https://cmake.org/cmake/help/latest/release/3.31.html I chose to bump to 3.10 out of extreme conservatism. But I don't know of any supported Linux systems that require anything that old. For context, Ubuntu 20.04 LTS shipped with 3.16. The oldest supported Debian release (bookworm) ships with 3.25.
sbc100
approved these changes
Mar 11, 2026
Member
|
Thanks! |
Contributor
Author
|
And thanks for merging! Would be lovely to get that in a release sooner than later so I can pull it into vcpkg. |
Member
|
Done. New release is out now. |
Contributor
Author
|
Thanks so much, Sam! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake versions 3.31 and newer have begun to warn that compatibility with CMake versions older than 3.10 will be removed. When that happens, this will stop working. For now, it issues annoying warnings.
See the 3.31 release notes: https://cmake.org/cmake/help/latest/release/3.31.html
I chose to bump to 3.10 out of extreme conservatism. But I don't know of any supported Linux systems that require anything that old. For context, Ubuntu 20.04 LTS shipped with 3.16. The oldest supported Debian release (bookworm) ships with 3.25.