Add command-line tests for minidump and samplerate#1
Open
mojomojomojo wants to merge 2 commits intoVerySleepy:masterfrom
Open
Add command-line tests for minidump and samplerate#1mojomojomojo wants to merge 2 commits intoVerySleepy:masterfrom
mojomojomojo wants to merge 2 commits intoVerySleepy:masterfrom
Conversation
Author
|
Out of curiosity, why is this a separate repo? |
Member
|
Thank you for this! I will try to make time to look at this and other PRs soon.
The files here are somewhat big and are binary files, people who just want to build Very Sleepy shouldn't be forced to download them (especially as Git will download all past versions of them by default). |
Author
|
Won't the git submodule things built into the main repo download them anyway? I mean, it seems like a standard thing to get all the submodules. I had to do that in order to build at all. |
Member
|
Only if you clone with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the two command-line parameters for which it is feasible to construct deterministic tests.