Add UseOnDuplicateKeyUpdateForSplitTables#983
Open
Traesh wants to merge 1 commit intoTrinityCore:masterfrom
Open
Add UseOnDuplicateKeyUpdateForSplitTables#983Traesh wants to merge 1 commit intoTrinityCore:masterfrom
Traesh wants to merge 1 commit intoTrinityCore:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an option to use INSERT ... ON DUPLICATE KEY UPDATE for split SQL generation on shared creature tables.
This avoids the current issue where separate passes for creature_template and creature_template_difficulty each emit their own DELETE + INSERT, causing one pass to remove data produced by the other.
Also included: Fix issues when the last line of creature or gob spawns are commented (temp spawn), meaning ending of the last non-commented line is a coma.