Remove network-interfaces, use os.networkInterfaces() directly#7195
Open
ryancbahan wants to merge 1 commit into04-03-04-03-remove-camelcase-keysfrom
Open
Remove network-interfaces, use os.networkInterfaces() directly#7195ryancbahan wants to merge 1 commit into04-03-04-03-remove-camelcase-keysfrom
ryancbahan wants to merge 1 commit into04-03-04-03-remove-camelcase-keysfrom
Conversation
The single usage was a validation check (ni.fromIp) that verifies an IP exists on a local internal IPv4 interface. Replaced with a ~10 line inline helper using Node's os.networkInterfaces(). Also removed the hand-written type declaration file. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 3, 2026
Contributor
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
This was referenced Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ni.fromIp()call indev-server-2024.tswith an inlineassertIpOnLocalInterface()helper using Node'sos.networkInterfaces()network-interfacesfrom cli-kit dependencies and delete the hand-written.d.tstype declaration