Skip to content

Remove ansi-colors, replace with lightweight inline utility #7193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryancbahan merged 2 commits into from
Apr 7, 2026
Merged

Remove ansi-colors, replace with lightweight inline utility #7193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f7fea3
Remove ansi-colors, inline ANSI escape codes at call sites
ryancbahan Apr 3, 2026
0cbbf25
Address review feedback: rename to colors, extract constants in log.js
ryancbahan Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/create-homebrew-pr.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import {Liquid} from 'liquidjs'
const require = createRequire(import.meta.url)
const {readFile, mkdir, lstat, copy, outputFile, pathExists, rm} = require('fs-extra')
const {program} = require('commander')
const colors = require('ansi-colors')
const colors = {green: (s) => `\x1b[32m${s}\x1b[39m`, bold: (s) => `\x1b[1m${s}\x1b[22m`}
import {withOctokit} from './github-utils.js'

const packagingDirectory = path.resolve(path.dirname(fileURLToPath(import.meta.url)), "../packaging")
Expand Down
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@
"@types/node": "18.19.70",
"@typescript-eslint/parser": "8.56.1",
"@vitest/coverage-istanbul": "^3.1.4",
"ansi-colors": "^4.1.3",
"bugsnag-build-reporter": "^2.0.0",
"commander": "^9.4.0",
"esbuild": "0.27.4",
Expand Down
3 changes: 0 additions & 3 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 12 additions & 6 deletions workspace/src/lint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,19 @@
#!/usr/bin/env node
import * as url from 'url'
import {promises as fs} from 'fs'

import * as path from 'pathe'
import fg from 'fast-glob'
import * as url from 'url'
import {promises as fs} from 'fs'
import {createRequire} from 'module'

const require = createRequire(import.meta.url)
const colors = require('ansi-colors')
const colors = {
bold: (string) => `\x1b[1m${string}\x1b[22m`,
dim: (string) => `\x1b[2m${string}\x1b[22m`,
green: Object.assign((string) => `\x1b[32m${string}\x1b[39m`, {
bold: (string) => `\x1b[1m\x1b[32m${string}\x1b[39m\x1b[22m`,
}),
red: Object.assign((string) => `\x1b[31m${string}\x1b[39m`, {
bold: (string) => `\x1b[1m\x1b[31m${string}\x1b[39m\x1b[22m`,
}),
}

const rootDirectory = path.join(url.fileURLToPath(new URL('.', import.meta.url)), '../..')
let exitCode = 0
Expand Down
8 changes: 4 additions & 4 deletions workspace/src/utils/log.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {createRequire} from 'module'

const require = createRequire(import.meta.url)
const colors = require('ansi-colors')
const colors = {
green: {bold: (string) => `\x1b[1m\x1b[32m${string}\x1b[39m\x1b[22m`},
gray: (string) => `\x1b[90m${string}\x1b[39m`,
}

export function logSection(title) {
console.info(colors.green.bold(title))
Expand Down
Loading