fix: update built-in-commands tests for plugin command#11980
Draft
roomote-v0[bot] wants to merge 1 commit intofeature/plugin-system-11974from
Draft
fix: update built-in-commands tests for plugin command#11980roomote-v0[bot] wants to merge 1 commit intofeature/plugin-system-11974from
roomote-v0[bot] wants to merge 1 commit intofeature/plugin-system-11974from
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the failing CI tests on PR #11975 (which addresses Issue #11974).
Problem
The
built-in-commands.spec.tstests were asserting exactly 1 built-in command (init), but the plugin system PR added a second built-in command (plugin). This caused 2 test failures on both Ubuntu and Windows CI.Changes
getBuiltInCommandstest to expect 2 commands (initandplugin)getBuiltInCommandNamestest to expect 2 namesplugincommand (verifies it referencesplugin.jsonandPluginManager)All 33 tests pass locally (8 built-in-commands + 25 plugin system tests).
Feedback and guidance are welcome.
Interactively review PR in Roo Code Cloud