Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds disk-related tests and updates the BackendlessUserAPI to support saving an optional token value. Key changes include adding tests for disk operations (testDisk and testGetAllParams), updating the API header to accept a default parameter for saving tokens, and modifying the implementation accordingly.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Tests/test.cpp | Added new tests for disk operations and renamed an existing test. |
| BackendlessUserAPI.hpp | Updated method signature for saveTokenOnDisk and added friend declaration for tests. |
| BackendlessUserAPI.cpp | Modified saveTokenOnDisk to allow an optional parameter override for the token. |
Comments suppressed due to low confidence (1)
Tests/test.cpp:48
- [nitpick] Consider adding an assertion to verify that the token is actually cleared from disk after calling removeTokenFromDisk, in order to improve test coverage.
void BackendlessQtTests::testDisk() {
| @@ -102,11 +102,11 @@ void BackendlessUserAPI::readTokenFromDisk() { | |||
| file.close(); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
[nitpick] Consider adding a comment or refactoring to clarify the dual behavior of saveTokenOnDisk when an additional value is provided versus when it defaults to userTokenValue.
Suggested change
| // Saves a token to disk. If an additional value is provided, it is saved instead of the default userTokenValue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.