Skip to content

docs(sdk): add MCP server env variable resolution for file-based agents#417

Merged
VascoSch92 merged 1 commit intomainfrom
vasco/mcp-docs
Mar 25, 2026
Merged

docs(sdk): add MCP server env variable resolution for file-based agents#417
VascoSch92 merged 1 commit intomainfrom
vasco/mcp-docs

Conversation

@VascoSch92
Copy link
Contributor

@VascoSch92 VascoSch92 commented Mar 25, 2026

  • I have read and reviewed the documentation changes to the best of my ability.
  • If the change is significant, I have run the documentation site locally and confirmed it renders as expected.

Summary of changes

@mintlify
Copy link

mintlify bot commented Mar 25, 2026

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
all-hands-ai 🟢 Ready View Preview Mar 25, 2026, 5:55 PM

Copy link
Contributor

@all-hands-bot all-hands-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Good taste - Clean, accurate documentation that solves a real problem.

Verified against upstream implementation in software-agent-sdk PR #2492. All claims match the actual code:

  • Environment variable resolution uses os.path.expandvars() with both ${VAR} and $VAR syntax
  • Recursively processes all string values in MCP server configs
  • Undefined variables are left unchanged as documented
  • Example shows realistic usage across different server types

This documents how users can avoid hard-coding secrets in agent definitions - straightforward and pragmatic. No issues found.

Copy link
Contributor

@xingyaoww xingyaoww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@VascoSch92 VascoSch92 merged commit 0e9778c into main Mar 25, 2026
8 checks passed
@VascoSch92 VascoSch92 deleted the vasco/mcp-docs branch March 25, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants