CLI: Rollback some versions for node 18 compatibility#1325
Open
josephjclark wants to merge 6 commits intomainfrom
Open
CLI: Rollback some versions for node 18 compatibility#1325josephjclark wants to merge 6 commits intomainfrom
josephjclark wants to merge 6 commits intomainfrom
Conversation
Collaborator
Author
|
All tests here break in node 18, both locally and in CI. Same on main. Not going to worry about this if it's not free because we shouldn't be in this state for very long. I have run a node18 pull with |
Collaborator
Author
|
It looks like we're going to put out a fix quickly, so I might not have to do this. Holding fire until I need it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rolling back a couple of versions for node 18 compatibility.
This is needed for github sync, which uses node 18 in the actions. We need to do something about that.
I've also restored the node 18 integration tests, as we clearly need them still
Fixes #1324 (sort of)
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy