Merged
Conversation
All to bump minimatch deps
Collaborator
Author
|
The ava update is causing me real problems. In a thing I don't really understand, ava 6.0 doesn't process.exit after tests have run - it waits for the test environment to finish all execution. I guess is good because it forces you to test your cleanup code. But a lot of our cleaning code is failing, and some deep debugging with claude is putting me (rightly or wrongly) deep into phoenix code. Not happy about the time this is now taking me. I may roll back the ava update and raise an issue just so that I can move on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears out a bunch of security alerts.
Major diffs: