Draft: [16.0][FIX] Project_task_code does not work with portal kanban sharing#1701
Draft: [16.0][FIX] Project_task_code does not work with portal kanban sharing#1701
Conversation
…tal sharing kanban
…ore portal sharing kanban
luisDIXMIT
left a comment
There was a problem hiding this comment.
Code review and tested on runboat, LGTM! Maybe the two commits can be squashed into one.
ntsirintanis
left a comment
There was a problem hiding this comment.
This PR is exactly the way to go. The code field is introduced in project_task_code, so the corresponding guards should also be properly defined there. Without this fix, installing project_task_code alone causes issues; For example, portal users cannot create tasks from the sharing kanban view when project_task_code is installed.
Installing project_task_code_portal currently hides the problem, since it adds the code field in protected fields, though that behavior belongs in the base module rather than the portal extension.
So this fine by me, and here is my approval.
It would also make sense to clean up the duplication in project_task_code_portal.
|
This PR has the |
This is a fix for portal_task_code where you can invite a portaluser to be a 'sharing user' so that they can access an interactive project Kanban on portal however when a portal user creates a task via the project sharing view an AccessError is raised because the code field introduced by OCA/project_task_code is not included in SELF_WRITABLE_FIELDS.
To reproduce: