[18.0][MIG] project_forecast_line: Migration to 18.0 by solomonprabu · Pull Request #1692 · OCA/project

solomonprabu · 2026-03-13T07:02:09Z

[Migrated] project_forecast_line to Odoo 18.0.

Note on Views:
I kept the inheritance targeting project.project_project_stage_view_tree. Even though Odoo 18 is moving toward _view_list naming, the base project module still uses the _view_tree ID for this record, so I've used that to avoid any reference errors.

in some cases, we could have capacity consumed by a task which was not matching a work capacity line in the period because of a faulty optimisation we were making which skipped the creation of lines with a capacity of 0 -> then we had no line on which to compute the negative consolidated capacity. We remove the optimisation to fix this case and show the problematic periods in the consolidated capacity graphs

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-15.0/project-15.0-project_forecast_line Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/

During some operations, forecast lines are deleted and recreated. This can lead to some hr.employee.forecast.role lines being deleted which leaves the forecast lines on the same period without a related document to store the consolidated capacity. Normally that line is recreated shortly afterwards but the creation does not recompute the link between the parent-less lines and the new one. This patches forces the recomputation when new lines are created.

…tion states" This reverts commit 82f5f36.

The idea is to have two consolidated forecast fields, instead of setting.

…orecast

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-15.0/project-15.0-project_forecast_line Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/

Add computed fields to written fields to trigger forecast lines update

Add hook for several UoM hours/days conversion

…oyee is not active

luisDIXMIT · 2026-03-16T06:58:39Z

Test are failing, review the use of flush_model in tests.

solomonprabu · 2026-03-18T10:26:47Z

Test are failing, review the use of flush_model in tests.

Tests are succeeding now!

luisDIXMIT · 2026-03-19T07:30:27Z

Test are failing, review the use of flush_model in tests.

Tests are succeeding now!

Nice, can you squash the commits into a single migration commit? Or, if you prefer, keep one migration commit and one improvement commit. I see too many commits, let’s keep the commit history simple.

tarteo · 2026-03-20T09:57:58Z

Can you take a look at these comments here and apply them when necessary #1247

solomonprabu · 2026-03-23T04:49:49Z

Can you take a look at these comments here and apply them when necessary #1247

Looking into it, will let you know once it is fixed.

solomonprabu · 2026-03-23T04:51:10Z

Test are failing, review the use of flush_model in tests.

Tests are succeeding now!

Nice, can you squash the commits into a single migration commit? Or, if you prefer, keep one migration commit and one improvement commit. I see too many commits, let’s keep the commit history simple.

I totally agree with you on this! will squash the commits once I'm done.

solomonprabu · 2026-03-23T05:40:33Z

Can you take a look at these comments here and apply them when necessary #1247

Fixed project task view

Fixed res.config.settings view

regarding [[16.0][MIG] project_forecast_line] #1247 I do not get the error on changing stages for the task.

solomonprabu · 2026-03-23T05:48:05Z

@tarteo

Is it better to use existing fields from project_timeline? #1247 (comment)

Regarding this, I had the same opinion on this. For now I do not see any complications on using the fields from project_timeline Yet I feel it is better to do the changes and run tests on both the modules locally to ensure that they are working as intended and do not interrupt any functions.

This could be time consuming though, if something falls apart!

solomonprabu · 2026-03-23T06:32:34Z

@tarteo Also using the field from project_timeline will create a installation dependency on project_timeline and web_timeline for project_forecast_timeline to be installed.

solomonprabu · 2026-03-23T08:59:55Z

@tarteo I have tested the files locally after replacing the fields from project_timeline. The tests pass. Let me if we're moving with these fields, depending on your decision I will push the code here.

tarteo

@solomonprabu Thanks for the fixes! The date fields can also be addressed later, it is out of scope for this migration PR.

IMO the ideal situation would be:

A module project_date that just introduces the fields
project_timeline depends on project_date (reusing those fields instead of adding new ones)
project_forecast_line depends on project_date (reusing those fields instead of adding new ones)

This way we avoid introducing a dependency on web_timeline, while still having any task planned using the forecast module reflected in the the project task timeline view.

solomonprabu · 2026-03-26T04:44:38Z

@solomonprabu Thanks for the fixes! The date fields can also be addressed later, it is out of scope for this migration PR.

IMO the ideal situation would be:
* A module `project_date` that just introduces the fields

* `project_timeline` depends on `project_date` (reusing those fields instead of adding new ones)

* `project_forecast_line` depends on `project_date` (reusing those fields instead of adding new ones)
This way we avoid introducing a dependency on web_timeline, while still having any task planned using the forecast module reflected in the the project task timeline view.

@tarteo
Thanks for the validation! I'm interested in your proposed idea and I believe it would be the cleanest possible way to handle this.

🙌 Cheers for the PR approval and have a good weekend :)

tarteo · 2026-03-26T10:35:02Z

When planning a task, it is not reflected in the forecast:

solomonprabu · 2026-03-26T13:11:50Z

When planning a task, it is not reflected in the forecast:

@tarteo The issue is in here, the _write method in project_task.py#L56-L62 is not being called or executed. Moving this method to ORM write method fixes it.

But that makes the forecast_recomputation_trigger field and its _compute method redundant.

solomonprabu · 2026-03-30T09:37:06Z

@tarteo The bug is now fixed!

solomonprabu · 2026-03-31T05:48:06Z

@luisDIXMIT All checks have passed.

luisDIXMIT · 2026-03-31T06:53:21Z

Nice, but could you squash the commits? It's too large. It should be squashed into a single migration commit, or perhaps into two commits if there are fixes or improvements outside the migration scope.

[FIX] Demo data xml to fix installation errors and warnings [FIX] Demo data xml to fix installation errors and warnings [FIX] Typo [FIX] Typo [FIX] Demo data xml to fix installation errors and warnings [FIX] fixed test case error, mis-calculations and xml errors [ADD] Improved test coverage and improved onchange method [FIX] Demo data xml to fix installation errors and warnings [FIX] Typo [FIX] fixed test case error, mis-calculations and xml errors [FIX] Pre commit errors [UPDATE] updated missing variable [UPDATE] updated missing variables [FIX] Typo [FIX] implemented feedbacks from PR OCA#1247 [UPDATE] Introduced new test case [DEL] removed duplicate code [FIX] reverting field changes to fix tests [UPDATE] Changing logger warning to info. To maintain clean logs and for pipeline to succeed, as warnings in log stops the container from succeeding [ADD] Added new testcases to improve code coverage [FIX] incorrect date object [UPDATE] fixing test method [ADD] Added test cases and refactored tests [FIX] fixing parameters [ADD] Hr Leave test coverage [FIX] Pre commit fix [FIX] logger warning to info [Add] Code coverage improvement [Add] Code coverage improvement for Hr Leave [UPDATE] Update _write method with _write_multi. Odoo18 changes

solomonprabu · 2026-03-31T09:41:53Z

Nice, but could you squash the commits? It's too large. It should be squashed into a single migration commit, or perhaps into two commits if there are fixes or improvements outside the migration scope.

Squashed! Ready to merge?

luisDIXMIT

Code review, good work, some minor comments.

project_forecast_line/demo/sale.xml

project_forecast_line/models/forecast_line.py

project_forecast_line/models/hr_leave.py

project_forecast_line/demo/project.xml

project_forecast_line/views/hr_employee_views.xml

luisDIXMIT

Good work, LGTM, I won't block the PR.

OCA-git-bot · 2026-04-01T13:41:54Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Review changes.

solomonprabu · 2026-04-02T12:28:48Z

@sebastienbeau PR is ready to be merged!

yankinmax and others added 30 commits March 10, 2026 15:24

[15.0][ADD] project_forecast_line

c84403e

[UPD] Update project_forecast_line.pot

6f3c374

[UPD] README.rst

1502de0

project_forecast_line: improve documentation

d95caae

[UPD] README.rst

8d10b6d

project_forecast_line 15.0.1.0.1

029286b

project_forecast_line 15.0.1.0.2

5e9da1d

[15.0][FIX] project_forecast_line: take roles into account on calc

3982552

[15.0][IMP] project_forecast_line: setting to control consumption states

1ad58bb

bump version after clicking on merge by mistake

02f10ef

[UPD] Update project_forecast_line.pot

7730c01

Update translation files

77dcc0b

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-15.0/project-15.0-project_forecast_line Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/

[15.0][FIX] project_forecast_line: add missing access rights

ec250f8

[UPD] README.rst

cdc1121

project_forecast_line 15.0.1.0.4

d13c709

project_forecast_line 15.0.1.0.5

dc7233b

Revert "[15.0][IMP] project_forecast_line: setting to control consump…

b3ac2ff

…tion states" This reverts commit 82f5f36.

[FIX] project_forecast_line:

3b0c9b3

The idea is to have two consolidated forecast fields, instead of setting.

[FIX] project_forecast_line: give sudo rights on hr.leave to create f…

b5775fd

…orecast

fix the computation of the field and the tests

4026f53

[UPD] Update project_forecast_line.pot

722f475

project_forecast_line 15.0.1.1.0

f290204

Update translation files

014c663

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-15.0/project-15.0-project_forecast_line Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/

[15.0][IMP] project_forecast_line:

f9e1de8

Add computed fields to written fields to trigger forecast lines update

[15.0][IMP] project_forecast_line:

2482473

Add hook for several UoM hours/days conversion

[IMP] Reorder search filters

3b54c08

project_forecast_line 15.0.1.1.1

307faf8

[15.0][UPD] project_forecast_line: update forecast lines even if empl…

309746b

…oyee is not active

solomonprabu mentioned this pull request Mar 17, 2026

Migration to version 18.0 #1347

Open

44 tasks

tarteo approved these changes Mar 25, 2026

View reviewed changes

solomonprabu force-pushed the 18.0-mig-project_forecast_line branch from 8ba64ac to 8ac84f3 Compare March 26, 2026 05:22

solomonprabu force-pushed the 18.0-mig-project_forecast_line branch from e92d97e to 8c5860a Compare March 31, 2026 09:32

luisDIXMIT reviewed Apr 1, 2026

View reviewed changes

[FIX] resolvig reviews

49534f0

luisDIXMIT approved these changes Apr 1, 2026

View reviewed changes

OCA-git-bot added approved ready to merge labels Apr 1, 2026

[UPDATE] removed redundant variable and looping over the method.

39750cc

Review changes.

Uh oh!

Conversation

solomonprabu commented Mar 13, 2026

Uh oh!

luisDIXMIT commented Mar 16, 2026

Uh oh!

solomonprabu commented Mar 18, 2026

Uh oh!

luisDIXMIT commented Mar 19, 2026

Uh oh!

tarteo commented Mar 20, 2026

Uh oh!

solomonprabu commented Mar 23, 2026

Uh oh!

solomonprabu commented Mar 23, 2026

Uh oh!

solomonprabu commented Mar 23, 2026

Uh oh!

solomonprabu commented Mar 23, 2026

Uh oh!

solomonprabu commented Mar 23, 2026

Uh oh!

solomonprabu commented Mar 23, 2026

Uh oh!

tarteo left a comment

Choose a reason for hiding this comment

Uh oh!

solomonprabu commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tarteo commented Mar 26, 2026

Uh oh!

solomonprabu commented Mar 26, 2026

Uh oh!

solomonprabu commented Mar 30, 2026

Uh oh!

solomonprabu commented Mar 31, 2026

Uh oh!

luisDIXMIT commented Mar 31, 2026

Uh oh!

solomonprabu commented Mar 31, 2026

Uh oh!

luisDIXMIT left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

luisDIXMIT left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Apr 1, 2026

Uh oh!

solomonprabu commented Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

solomonprabu commented Mar 26, 2026 •

edited

Loading