Skip to content

[18.0][MIG] hr_contract_document#1526

Open
mathieudelva wants to merge 27 commits intoOCA:18.0from
akretion:18.0-mig-hr_contract_document
Open

[18.0][MIG] hr_contract_document#1526
mathieudelva wants to merge 27 commits intoOCA:18.0from
akretion:18.0-mig-hr_contract_document

Conversation

@mathieudelva
Copy link
Copy Markdown

@mathieudelva mathieudelva commented Nov 20, 2025

Standard migration

@Kev-Roche @PaulGoubert

alexey-pelykh and others added 26 commits November 19, 2025 15:59
Currently translated at 100.0% (4 of 4 strings)

Translation: hr-13.0/hr-13.0-hr_contract_document
Translate-URL: https://translation.odoo-community.org/projects/hr-13-0/hr-13-0-hr_contract_document/es/
Currently translated at 100.0% (7 of 7 strings)

Translation: hr-14.0/hr-14.0-hr_contract_document
Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_contract_document/it/
Currently translated at 100.0% (7 of 7 strings)

Translation: hr-14.0/hr-14.0-hr_contract_document
Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_contract_document/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: hr-14.0/hr-14.0-hr_contract_document
Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_contract_document/
Currently translated at 100.0% (7 of 7 strings)

Translation: hr-14.0/hr-14.0-hr_contract_document
Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_contract_document/es/
@mathieudelva mathieudelva mentioned this pull request Nov 20, 2025
23 tasks
Copy link
Copy Markdown

@PaulGoubert PaulGoubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
only one small comment

"license": "AGPL-3",
"installable": True,
"application": False,
"summary": "Documents attached to the contact",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documents attached to the contract

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed

Copy link
Copy Markdown

@PaulGoubert PaulGoubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tout fonctionne bien dans l'état.

<div name="button_box" position="inside">
<button
class="oe_stat_button"
icon="fa-book"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fa-paperclip plus intuitif non ?

"default_res_model": self._name,
"default_res_id": self.ids[0],
}
action["domain"] = str(
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plutot une list non ?

"license": "AGPL-3",
"installable": True,
"application": False,
"summary": "Documents attached to the contact",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed

@mathieudelva mathieudelva force-pushed the 18.0-mig-hr_contract_document branch from bcf74eb to 6e1b5f5 Compare January 17, 2026 14:09
@mathieudelva mathieudelva force-pushed the 18.0-mig-hr_contract_document branch from 6e1b5f5 to 49af120 Compare January 17, 2026 14:11
Copy link
Copy Markdown
Contributor

@alexey-pelykh alexey-pelykh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on! As the original module author, code review LGTM -- clean migration.

Regarding the open feedback from @PaulGoubert and @Kev-Roche: agree the manifest summary could be improved. Worth pushing a quick fix to resolve the CHANGES_REQUESTED.

Copy link
Copy Markdown
Contributor

@BhaveshHeliconia BhaveshHeliconia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.