[14.0][FIX] sale_commission_product_criteria: address same label warning

[HekkiMelody]

Fixes the following warning

2026-03-31 12:14:35,919 1 WARNING devel odoo.addons.base.models.ir_model: Two fields (commission_type, commission_id) of commission.item() have the same label: Commission Type. 

[OCA-git-bot]

Hi @PicchiSeba, @ilyasProgrammer, @renda-dev, @aleuffre,
some modules you are maintaining are being modified, check this out!

[HekkiMelody]

Pre-commit failure addressed in #670

[SirPyTech]

Before this change both commission_type and commission are labeled Commission Type.
After this change commission_type is labeled Type and commission is labeled Commission Type.
I think the new behavior is just as confusing as the old one.

Maybe the real problem is a few lines above:

    commission_id = fields.Many2one(
        "sale.commission",
        string="Commission Type",

why don't we:

• label commission_id as Commission
• label commission_type as Commission Type

?

This would also be aligned with 18.0, see

commission/sale_commission_oca_product_criteria/models/commission.py

Lines 73 to 78 in 2fefe98

	commission_id = fields.Many2one(
	"commission",
	string="Commission",
	domain=[("commission_type", "=", "product")],
	required=True,
	)

and

commission/sale_commission_oca_product_criteria/models/commission.py

Lines 120 to 125 in 2fefe98

	commission_type = fields.Selection(
	[("fixed", "Fixed"), ("percentage", "Percentage")],
	index=True,
	default="fixed",
	required=True,
	)

.

In order to achieve this result, we can just remove string from both fields, or change Commission Type to Commission as it is in 18.0.
What do you think?

[HekkiMelody]

Removed string attribute from both fields (fewer lines of code is always good!) to adhere to the same nomenclature as v18.

Thank you for the suggestion.

[SirPyTech]

👍

[SirPyTech]

👍

[SirPyTech]

Rebased to include #670.

[francesco-ooops]

LGTM

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖