tech: enable watch mode & esbuild server in dev mode#674
Draft
ErwanRaulo wants to merge 1 commit intoNodeSecure:masterfrom
Draft
tech: enable watch mode & esbuild server in dev mode#674ErwanRaulo wants to merge 1 commit intoNodeSecure:masterfrom
ErwanRaulo wants to merge 1 commit intoNodeSecure:masterfrom
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
clemgbld
requested review from
PierreDemailly and
fraxken
and removed request for
fraxken
Member
|
Not a big fan of duplicating code (http etc) |
fraxken
reviewed
Mar 11, 2026
Comment on lines
-66
to
+57
| httpServer.listen(httpPort, async() => { | ||
| const link = `http://localhost:${httpServer.address().port}`; | ||
| console.log(kleur.magenta().bold(await i18n.getToken("cli.http_server_started")), kleur.cyan().bold(link)); | ||
|
|
||
| open(link); | ||
| }); | ||
| if (enableDeveloperMode) { | ||
| // todo: ping/warn if dev server is not up & running | ||
| open("http://127.0.0.1:8080"); | ||
| } |
Member
There was a problem hiding this comment.
Hmm there is something wrong with how the code is modified here. Before we had a clean open but now only one simple open when enabledDeveloperMode is true?
Contributor
Author
There was a problem hiding this comment.
yes, not really what i wanted to do, it miss the translation for dev mode, keeping the clean open in place.
watch esbuild config file now it opens the link like this with current nsecure result.
so maybe we should tell something in scenarios like:
- "dev server not running ?"
- " dev server listening on ...."
Contributor
Author
i ended up removing duplication. |
ErwanRaulo
force-pushed
the
watch-mode
branch
2 times, most recently
from
2971aff to
83933fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what it does
esbuild config to watch and serve fle for auto reload on served files changes.
features
or
commands tested : nsecure auto
to validate:
to fix: