Fixed UPnP for full URLs with scheme#2451
Open
ypopovych wants to merge 1 commit intoMusicPlayerDaemon:v0.24.xfrom
Open
Fixed UPnP for full URLs with scheme#2451ypopovych wants to merge 1 commit intoMusicPlayerDaemon:v0.24.xfrom
ypopovych wants to merge 1 commit intoMusicPlayerDaemon:v0.24.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2450
To be frank I have zero confidence in URL fix, I simply patched two URL methods to return relative if it has scheme.
XML parser fix is a better one. Current version breaks on URLs with parameters. Parser sends URL by parts split on each
&. With this fix all of them will be concatenated together.Tested on Jellyfin server - works fine (slow, but works).