Open
Conversation
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
| ### Authentication | ||
|
|
||
| Get your users started in seconds with familiar login methods they already use: | ||
| Help users get started quickly with login methods they already use: |
Contributor
There was a problem hiding this comment.
Suggested change
| Help users get started quickly with login methods they already use: | |
| Help users get started quickly with sign-in methods they already use: |
| - Distributed architecture prevents single points of failure | ||
| - Multiple backup options for worry-free recovery | ||
| - Users maintain 100% control of their non-custodial wallets. | ||
| - A distributed architecture prevents single points of failure |
Contributor
There was a problem hiding this comment.
Suggested change
| - A distributed architecture prevents single points of failure | |
| - A distributed architecture prevents single points of failure. |
Comment on lines
+35
to
+36
| <source srcset={PnPCoreKitFlowLight} media="(prefers-color-scheme: light)" /> | ||
| <source srcset={PnPCoreKitFlowDark} media="(prefers-color-scheme: dark)" /> |
Contributor
There was a problem hiding this comment.
The light image appears on both light and dark mode for me (however, this is not a regression as the current site has the same behavior).
| </BrowserOnly> | ||
| Users get a smoother onboarding experience while retaining control of non-custodial wallets. | ||
|
|
||
| ## Key features |
Contributor
There was a problem hiding this comment.
The items in these lists are not fully consistent in sentence structure. We should call this out in the cursor rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
information (accessibility issue).
Issue(s) fixed
Fixes #2782
Preview
https://metamask-docs-git-doc-2782-consensys-ddffed67.vercel.app/embedded-wallets/
Checklist
Note
Low Risk
Documentation-only changes plus a new static SVG asset and sidebar entry; no runtime product logic changes, with minimal risk limited to broken links/assets or rendering issues.
Overview
Updates the Embedded Wallets landing page (
embedded-wallets/README.mdx) to be more concise/less marketing-focused, adds an onboarding comparison graphic, and removes the client-only modal/inline architecture content in favor of a single link.Introduces a new dedicated
embedded-wallets/architecture.mdxdoc that explains the high-level login/key-share flow and hosts the existing architecture diagram and wallet infrastructure overview, and adds it to the docs sidebar (ew-sidebar.js).Reviewed by Cursor Bugbot for commit 299db2f. Bugbot is set up for automated code reviews on this repo. Configure here.