Remove defc_a and defc_b from the init_atmosphere and atmosphere cores#1422
Merged
mgduda merged 1 commit intoMPAS-Dev:developfrom Mar 20, 2026
Merged
Remove defc_a and defc_b from the init_atmosphere and atmosphere cores#1422mgduda merged 1 commit intoMPAS-Dev:developfrom
mgduda merged 1 commit intoMPAS-Dev:developfrom
Conversation
With the introduction of the deformation_coef_* fields in merge commit 63f2d44 (PR MPAS-Dev#1405), the defc_a and defc_b fields are no longer needed in either the init_atmosphere or the atmosphere core. Accordingly, this commit removes the defc_a and defc_b fields from the Registry.xml files as well as source code in both of these cores.
abishekg7
approved these changes
Mar 20, 2026
Collaborator
abishekg7
left a comment
abishekg7
left a comment
There was a problem hiding this comment.
Tested the atmosphere and init_atmosphere cores. Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
defc_aanddefc_bfields from theinit_atmosphereandatmospherecores.With the introduction of the
deformation_coef_*fields in merge commit 63f2d44 (PR #1405), thedefc_aanddefc_bfields are no longer needed in either theinit_atmospherecore or theatmospherecore. Accordingly, this PR removes thedefc_aanddefc_bfields from theRegistry.xmlfiles as well as from the source code of both of these cores.