Improve sunrise/set method names#254
Merged
KosherJava merged 6 commits intoKosherJava:3-0-modernizationfrom Mar 16, 2026
Merged
Improve sunrise/set method names#254KosherJava merged 6 commits intoKosherJava:3-0-modernizationfrom
KosherJava merged 6 commits intoKosherJava:3-0-modernizationfrom
Conversation
…e correct SUNRISE enum in getInstantFromTime
Fix javadoc on `isUseElevation`
dickermoshe
added a commit
to dickermoshe/zmanim
that referenced
this pull request
Mar 18, 2026
46d39f5 Improve sunrise/set method names (KosherJava#254) git-subtree-dir: test/java git-subtree-split: 46d39f5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
getSunsettogetSunsetWithElevation. Same for sunset.Fixes docs on
isUseElevation