Backport "Remove assertions in "src/precompile.jl" (#254)"#320
Backport "Remove assertions in "src/precompile.jl" (#254)"#320Kyjor wants to merge 4 commits intoJuliaMath:release-0.8from
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-0.8 #320 +/- ##
===============================================
- Coverage 94.79% 88.70% -6.09%
===============================================
Files 6 6
Lines 538 496 -42
===============================================
- Hits 510 440 -70
- Misses 28 56 +28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Can I ask, Why do precompile statements fail when using Package Compiler in the first place? I can't find much info on this online. Also, do more changes need to be made to this PR to satisfy the CodeCov bot or are we just waiting for somebody to override it? |
|
@heyx3 honestly, I'm not sure about why they fail, but it seems like there was a bigger discussion about removing these previously: JuliaGraphics/ColorTypes.jl#232 (comment). Seems like it was more about performance? Also I didn't add any coverage as it doesn't seem to make any sense (at least as far as I understand) to test precompilation. If needed, I can do it though. At this point I'm just hoping someone who manages this repo sees this relatively soon. I've had to remove a dependency from my game engine temporarily so I can continue to build my game. Not a big deal for me for now, but I'm sure a few more people are depending on this downstream than just us |
Uh oh!
There was an error while loading. Please reload this page.