Skip to content

Backport "Remove assertions in "src/precompile.jl" (#254)"#320

Open
Kyjor wants to merge 4 commits intoJuliaMath:release-0.8from
Kyjor:bugfix/remove-asserts-from-precompile
Open

Backport "Remove assertions in "src/precompile.jl" (#254)"#320
Kyjor wants to merge 4 commits intoJuliaMath:release-0.8from
Kyjor:bugfix/remove-asserts-from-precompile

Conversation

@Kyjor
Copy link

@Kyjor Kyjor commented Mar 11, 2026

  • Cherry-picked commit #59ee94b
  • Bumped version number
  • Removed macos-13 os from the matrix. No longer supported by actions.
  • Updated arm action version, as the current on no longer works.

@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.70%. Comparing base (73917f8) to head (32a4edc).

Files with missing lines Patch % Lines
src/precompile.jl 0.00% 12 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (73917f8) and HEAD (32a4edc). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (73917f8) HEAD (32a4edc)
19 15
Additional details and impacted files
@@               Coverage Diff               @@
##           release-0.8     #320      +/-   ##
===============================================
- Coverage        94.79%   88.70%   -6.09%     
===============================================
  Files                6        6              
  Lines              538      496      -42     
===============================================
- Hits               510      440      -70     
- Misses              28       56      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@heyx3
Copy link

heyx3 commented Mar 14, 2026

Can I ask, Why do precompile statements fail when using Package Compiler in the first place? I can't find much info on this online.

Also, do more changes need to be made to this PR to satisfy the CodeCov bot or are we just waiting for somebody to override it?

@Kyjor
Copy link
Author

Kyjor commented Mar 14, 2026

@heyx3 honestly, I'm not sure about why they fail, but it seems like there was a bigger discussion about removing these previously: JuliaGraphics/ColorTypes.jl#232 (comment). Seems like it was more about performance?

Also I didn't add any coverage as it doesn't seem to make any sense (at least as far as I understand) to test precompilation. If needed, I can do it though. At this point I'm just hoping someone who manages this repo sees this relatively soon.

I've had to remove a dependency from my game engine temporarily so I can continue to build my game. Not a big deal for me for now, but I'm sure a few more people are depending on this downstream than just us

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants