[Snyk] Security upgrade @codecademy/gamut from 0.0.0-use.local to 1.1.0#3298
[Snyk] Security upgrade @codecademy/gamut from 0.0.0-use.local to 1.1.0#3298codecademydev wants to merge 1 commit intomainfrom
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-YAML-15765520
|
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9fe1aef3c5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "author": "Codecademy Engineering <dev@codecademy.com>", | ||
| "dependencies": { | ||
| "@codecademy/gamut": "68.2.1", | ||
| "@codecademy/gamut": "1.1.0", |
There was a problem hiding this comment.
Keep gamut-kit on the workspace gamut release line
This change downgrades @codecademy/gamut from 68.2.1 to 1.1.0, while the in-repo workspace package is still 68.2.1 (packages/gamut/package.json). Because the version no longer matches, Yarn stops resolving this dependency to workspace:packages/gamut (currently represented in yarn.lock as @codecademy/gamut@npm:68.2.1, @codecademy/gamut@workspace:packages/gamut) and will pull the published 1.1.0 package instead, so gamut-kit no longer builds/tests against the local monorepo source.
Useful? React with 👍 / 👎.
| "author": "Codecademy Engineering <dev@codecademy.com>", | ||
| "dependencies": { | ||
| "@codecademy/gamut": "68.2.1", | ||
| "@codecademy/gamut": "1.1.0", |
There was a problem hiding this comment.
Regenerate lockfile for the new gamut dependency
The dependency spec was changed without updating yarn.lock. Our shared CI action (.github/actions/yarn/action.yml) runs yarn install --immutable, and Yarn's --help explicitly states this mode exits with an error if the lockfile would be modified. Since the lockfile currently has no @codecademy/gamut@npm:1.1.0 entry, workflows using this action will fail during dependency installation until the lockfile is updated.
Useful? React with 👍 / 👎.
Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
packages/gamut-kit/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-YAML-15765520
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.