Fix incorrect block progress calculation in header download log#204
Merged
philippem merged 1 commit intoBlockstream:new-indexfrom Apr 7, 2026
Merged
Conversation
tip_height is 0-indexed, so the total header count is tip_height + 1. Using tip_height as the denominator caused >100% progress (e.g. 200% with 2 blocks) and division by zero when tip_height is 0. Fixes Blockstream#197
Randy808
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
downloaded X/Y block headers (Z%)log inget_all_headersusestip_heightas the denominator, buttip_heightis 0-indexed whileresult.len()counts total headers. This causes:tip_height=1, logging2/1 (200%)tip_height=0The fix uses
tip_height + 1as the denominator, which matches the actual header count (0..=tip_height).Fixes #197