Merged
Conversation
changed the way script_dir is found to not call on bash
Removes a bash requirement for the env call
Contributor
|
That wasn't intended to be snarky, I apologize if it came off that way. In my testing, this seems compatible with sh, so looks good to me. However, I believe the shebang should either be |
Contributor
Author
|
Done, never tested outside of using sh to runner the command, didn't think about it. |
lambdcalculus
approved these changes
Jul 29, 2025
Contributor
lambdcalculus
left a comment
lambdcalculus
left a comment
There was a problem hiding this comment.
LGTM then! Thanks you for the improvement here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw a snarky comment or some such that to actually be bash independent, we'd need to rewrite the code for identifying the local filesystem. They were right, and so I used an alternative method here, which to the end user works entirely the same. Technically its not function in sh, but none of our processes were functional in sh anyway.